-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Absolute Flux Calculation Fix #120
Conversation
Let me know if/when you want a review on this! |
@hover2pi |
I added some tests and I think this is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Thanks for writing these tests!
Oh, to answer your question above, we could run this test on a specific source and compare against some values from the literature. That would be great, though I don't think there are any verification tests with actual sources besides Vega. I would say add verification tests in a later PR and merge this now. |
sounds good, I am going to merge! is that good @hover2pi ? |
@SherelynA , you can squash and merge this. Once done, I can make a new release. |
Patch to fix absolute flux calculation which is is missing a square.